Skip to content

Merge pull request #35 from idky137/add_walletrpc #78

Merge pull request #35 from idky137/add_walletrpc

Merge pull request #35 from idky137/add_walletrpc #78

Triggered via push July 18, 2024 14:09
Status Failure
Total duration 23m 28s
Artifacts

ci.yml

on: push
Matrix: build-latest
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

22 errors and 4 warnings
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
Rustfmt
Process completed with exit code 1.
Latest build on ubuntu-latest
Process completed with exit code 101.
Latest build on macOS-latest
The job was canceled because "ubuntu-latest" failed.
Latest build on windows-latest
The job was canceled because "ubuntu-latest" failed.
Latest build on windows-latest
The operation was canceled.
unneeded `return` statement: zingo-rpc/src/walletrpc/service.rs#L447
error: unneeded `return` statement --> zingo-rpc/src/walletrpc/service.rs:447:25 | 447 | / return Err(Status::invalid_argument(format!( 448 | | "Failed to parse nym address: {}", 449 | | e 450 | | ))); | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 447 ~ Err(Status::invalid_argument(format!( 448 + "Failed to parse nym address: {}", 449 + e 450 ~ ))) |
unneeded `return` statement: zingo-rpc/src/walletrpc/service.rs#L447
error: unneeded `return` statement --> zingo-rpc/src/walletrpc/service.rs:447:25 | 447 | / return Err(Status::invalid_argument(format!( 448 | | "Failed to parse nym address: {}", 449 | | e 450 | | ))); | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 447 ~ Err(Status::invalid_argument(format!( 448 + "Failed to parse nym address: {}", 449 + e 450 ~ ))) |
unneeded `return` statement: zingo-rpc/src/walletrpc/service.rs#L259
error: unneeded `return` statement --> zingo-rpc/src/walletrpc/service.rs:259:25 | 259 | / return Err(Status::invalid_argument(format!( 260 | | "Failed to parse nym address: {}", 261 | | e 262 | | ))); | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 259 ~ Err(Status::invalid_argument(format!( 260 + "Failed to parse nym address: {}", 261 + e 262 ~ ))) |
unneeded `return` statement: zingo-rpc/src/walletrpc/service.rs#L259
error: unneeded `return` statement --> zingo-rpc/src/walletrpc/service.rs:259:25 | 259 | / return Err(Status::invalid_argument(format!( 260 | | "Failed to parse nym address: {}", 261 | | e 262 | | ))); | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 259 ~ Err(Status::invalid_argument(format!( 260 + "Failed to parse nym address: {}", 261 + e 262 ~ ))) |
needlessly taken reference of both operands: zingo-rpc/src/nym/utils.rs#L20
error: needlessly taken reference of both operands --> zingo-rpc/src/nym/utils.rs:20:8 | 20 | if &body_len != &data[cursor.position() as usize..].len() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `-D clippy::op-ref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::op_ref)]` help: use the values directly | 20 | if body_len != data[cursor.position() as usize..].len() { | ~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
needlessly taken reference of both operands: zingo-rpc/src/nym/utils.rs#L20
error: needlessly taken reference of both operands --> zingo-rpc/src/nym/utils.rs:20:8 | 20 | if &body_len != &data[cursor.position() as usize..].len() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `-D clippy::op-ref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::op_ref)]` help: use the values directly | 20 | if body_len != data[cursor.position() as usize..].len() { | ~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Clippy (MSRV)
Clippy had exited with the 101 exit code
Code coverage
Process completed with exit code 1.
Test on windows-latest
Process completed with exit code 1.
Test on macOS-latest
The job was canceled because "windows-latest" failed.
unneeded `return` statement: zingo-rpc/src/walletrpc/service.rs#L447
error: unneeded `return` statement --> zingo-rpc/src/walletrpc/service.rs:447:25 | 447 | / return Err(Status::invalid_argument(format!( 448 | | "Failed to parse nym address: {}", 449 | | e 450 | | ))); | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 447 ~ Err(Status::invalid_argument(format!( 448 + "Failed to parse nym address: {}", 449 + e 450 ~ ))) |
unneeded `return` statement: zingo-rpc/src/walletrpc/service.rs#L447
error: unneeded `return` statement --> zingo-rpc/src/walletrpc/service.rs:447:25 | 447 | / return Err(Status::invalid_argument(format!( 448 | | "Failed to parse nym address: {}", 449 | | e 450 | | ))); | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 447 ~ Err(Status::invalid_argument(format!( 448 + "Failed to parse nym address: {}", 449 + e 450 ~ ))) |
unneeded `return` statement: zingo-rpc/src/walletrpc/service.rs#L259
error: unneeded `return` statement --> zingo-rpc/src/walletrpc/service.rs:259:25 | 259 | / return Err(Status::invalid_argument(format!( 260 | | "Failed to parse nym address: {}", 261 | | e 262 | | ))); | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 259 ~ Err(Status::invalid_argument(format!( 260 + "Failed to parse nym address: {}", 261 + e 262 ~ ))) |
unneeded `return` statement: zingo-rpc/src/walletrpc/service.rs#L259
error: unneeded `return` statement --> zingo-rpc/src/walletrpc/service.rs:259:25 | 259 | / return Err(Status::invalid_argument(format!( 260 | | "Failed to parse nym address: {}", 261 | | e 262 | | ))); | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 259 ~ Err(Status::invalid_argument(format!( 260 + "Failed to parse nym address: {}", 261 + e 262 ~ ))) |
needlessly taken reference of both operands: zingo-rpc/src/nym/utils.rs#L20
error: needlessly taken reference of both operands --> zingo-rpc/src/nym/utils.rs:20:8 | 20 | if &body_len != &data[cursor.position() as usize..].len() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `-D clippy::op-ref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::op_ref)]` help: use the values directly | 20 | if body_len != data[cursor.position() as usize..].len() { | ~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
needlessly taken reference of both operands: zingo-rpc/src/nym/utils.rs#L20
error: needlessly taken reference of both operands --> zingo-rpc/src/nym/utils.rs:20:8 | 20 | if &body_len != &data[cursor.position() as usize..].len() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `-D clippy::op-ref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::op_ref)]` help: use the values directly | 20 | if body_len != data[cursor.position() as usize..].len() { | ~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (MSRV)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/