-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zebra dependency #220
Conversation
cc9a817
to
35e2677
Compare
add some missing fields, which propogate.,,
35e2677
to
031c603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I added an issue for one of the TODO's and I don't understand what's the task itself to create it.
Im getting failures when running tests with zcashd, I think we may have to make the new fields Errors:
For tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
untested acknowledge (utAck). only outstanding thing is the comment of the issue I opened for the todo
I have added the issue AloeareV created (#221) to the "new index" task (#193) in Zaino's new Dev Milestone Tracker (https://github.com/zingolabs/zaino/milestone/10) |
Co-authored-by: Pacu <francisco.gindre@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New drop logic creates test hangs:
$ cargo nextest run wallet_basic
Finished `test` profile [optimized + debuginfo] target(s) in 0.24s
Starting 14 tests across 9 binaries (127 skipped)
TRY 1 SLOW [> 60.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [> 60.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [> 60.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [> 60.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
TRY 1 SLOW [>120.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [>120.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [>120.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [>120.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
TRY 1 SLOW [>180.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [>180.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [>180.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [>180.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
TRY 1 SLOW [>240.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [>240.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [>240.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [>240.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
TRY 1 SLOW [>300.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [>300.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [>300.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [>300.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
TRY 1 SLOW [>360.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [>360.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [>360.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [>360.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
TRY 1 SLOW [>420.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [>420.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [>420.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [>420.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
TRY 1 SLOW [>480.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [>480.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [>480.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [>480.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
TRY 1 SLOW [>540.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [>540.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [>540.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [>540.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
TRY 1 SLOW [>600.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [>600.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [>600.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [>600.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
TRY 1 SLOW [>660.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
TRY 1 SLOW [>660.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
TRY 1 SLOW [>660.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
TRY 1 SLOW [>660.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
Running [ 00:11:12] [ ] 0/14 : 4 running, 0 passed, 37 skipped Canceling due to interrupt: 4 tests still running
SIGINT [ 672.619s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
SIGINT [ 672.624s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
SIGINT [ 672.631s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
SIGINT [ 672.633s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
------------
Summary [ 672.634s] 4/14 tests run: 0 passed, 4 failed, 37 skipped
```
Zebra-rpc has added roughly a kajillion fields to GetInfo and GetBlockchainInfo, this updates zaino to use those fields as well.