Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zebra dependency #220

Merged
merged 16 commits into from
Feb 27, 2025
Merged

Update zebra dependency #220

merged 16 commits into from
Feb 27, 2025

Conversation

AloeareV
Copy link
Contributor

Zebra-rpc has added roughly a kajillion fields to GetInfo and GetBlockchainInfo, this updates zaino to use those fields as well.

@AloeareV AloeareV force-pushed the update_lock branch 2 times, most recently from cc9a817 to 35e2677 Compare February 21, 2025 21:27
Copy link
Contributor

@pacu pacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I added an issue for one of the TODO's and I don't understand what's the task itself to create it.

@idky137
Copy link
Contributor

idky137 commented Feb 24, 2025

Im getting failures when running tests with zcashd, I think we may have to make the new fields Option<field> to be backwards compatible with zcashd.

Errors:

--- STDERR:              zaino-state fetch::tests::launch_fetch_service_zebrad_regtest_no_cache ---
thread 'fetch::tests::launch_fetch_service_zebrad_regtest_no_cache' panicked at zaino-state/src/fetch.rs:1771:10:
called `Result::unwrap()` on an `Err` value: JsonRpcConnectorError(SerdeJsonError(Error("missing field `version`", line: 1, column: 92)))

--- STDERR:              zaino-state fetch::tests::fetch_service_z_get_treestate_zcashd ---
thread 'fetch::tests::fetch_service_z_get_treestate_zcashd' panicked at /home/idky137/src/zaino/zaino-testutils/src/lib.rs:388:18:
called `Result::unwrap()` on an `Err` value: FetchServiceError(JsonRpcConnectorError(SerdeJsonError(Error("invalid type: integer `1740406607`, expected a string", line: 1, column: 360))))

For tests:

------------
     Summary [  84.652s] 30 tests run: 0 passed, 30 failed, 85 skipped
        FAIL [   9.427s] zaino-state fetch::tests::fetch_service_get_address_balance_zcashd
        FAIL [  10.457s] zaino-state fetch::tests::fetch_service_get_address_tx_ids_zcashd
        FAIL [  10.458s] zaino-state fetch::tests::fetch_service_get_address_utxos_zcashd
        FAIL [  10.458s] zaino-state fetch::tests::fetch_service_get_block_nullifiers_zcashd
        FAIL [   8.299s] zaino-state fetch::tests::fetch_service_get_block_object_zcashd
        FAIL [   9.974s] zaino-state fetch::tests::fetch_service_get_block_range_nullifiers_zcashd
        FAIL [   9.962s] zaino-state fetch::tests::fetch_service_get_block_range_zcashd
        FAIL [   9.967s] zaino-state fetch::tests::fetch_service_get_block_raw_zcashd
        FAIL [   8.723s] zaino-state fetch::tests::fetch_service_get_block_zcashd
        FAIL [   9.010s] zaino-state fetch::tests::fetch_service_get_latest_block_zcashd
        FAIL [   9.002s] zaino-state fetch::tests::fetch_service_get_latest_tree_state_zcashd
        FAIL [   8.995s] zaino-state fetch::tests::fetch_service_get_lightd_info_zcashd
        FAIL [   7.980s] zaino-state fetch::tests::fetch_service_get_mempool_stream_zcashd
        FAIL [   8.998s] zaino-state fetch::tests::fetch_service_get_mempool_tx_zcashd
        FAIL [   8.990s] zaino-state fetch::tests::fetch_service_get_raw_mempool_zcashd
        FAIL [   8.986s] zaino-state fetch::tests::fetch_service_get_raw_transaction_zcashd
        FAIL [   8.003s] zaino-state fetch::tests::fetch_service_get_subtree_roots_zcashd
        FAIL [   8.996s] zaino-state fetch::tests::fetch_service_get_taddress_balance_zcashd
        FAIL [   8.995s] zaino-state fetch::tests::fetch_service_get_taddress_txids_zcashd
        FAIL [   8.989s] zaino-state fetch::tests::fetch_service_get_taddress_utxos_stream_zcashd
        FAIL [   8.049s] zaino-state fetch::tests::fetch_service_get_taddress_utxos_zcashd
        FAIL [  10.113s] zaino-state fetch::tests::fetch_service_get_transaction_mempool_zcashd
        FAIL [  10.100s] zaino-state fetch::tests::fetch_service_get_transaction_mined_zcashd
        FAIL [  10.151s] zaino-state fetch::tests::fetch_service_get_tree_state_zcashd
        FAIL [   8.975s] zaino-state fetch::tests::fetch_service_z_get_subtrees_by_index_zcashd
        FAIL [   7.899s] zaino-state fetch::tests::fetch_service_z_get_treestate_zcashd
        FAIL [   7.894s] zaino-state fetch::tests::launch_fetch_service_zcashd_regtest_no_cache
        FAIL [   6.037s] zaino-state fetch::tests::launch_fetch_service_zcashd_regtest_with_cache
        FAIL [  20.948s] zaino-state fetch::tests::launch_fetch_service_zebrad_regtest_no_cache
        FAIL [  21.049s] zaino-state fetch::tests::launch_fetch_service_zebrad_regtest_with_cache
error: test run failed

pacu
pacu previously approved these changes Feb 24, 2025
Copy link
Contributor

@pacu pacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested acknowledge (utAck). only outstanding thing is the comment of the issue I opened for the todo

@idky137
Copy link
Contributor

idky137 commented Feb 25, 2025

I have added the issue AloeareV created (#221) to the "new index" task (#193) in Zaino's new Dev Milestone Tracker (https://github.com/zingolabs/zaino/milestone/10)

idky137
idky137 previously approved these changes Feb 26, 2025
Co-authored-by: Pacu <francisco.gindre@gmail.com>
idky137
idky137 previously approved these changes Feb 26, 2025
idky137
idky137 previously approved these changes Feb 26, 2025
Copy link
Contributor

@idky137 idky137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New drop logic creates test hangs:

$ cargo nextest run wallet_basic
    Finished `test` profile [optimized + debuginfo] target(s) in 0.24s
    Starting 14 tests across 9 binaries (127 skipped)
  TRY 1 SLOW [> 60.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [> 60.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [> 60.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [> 60.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
  TRY 1 SLOW [>120.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [>120.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [>120.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [>120.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
  TRY 1 SLOW [>180.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [>180.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [>180.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [>180.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
  TRY 1 SLOW [>240.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [>240.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [>240.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [>240.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
  TRY 1 SLOW [>300.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [>300.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [>300.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [>300.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
  TRY 1 SLOW [>360.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [>360.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [>360.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [>360.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
  TRY 1 SLOW [>420.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [>420.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [>420.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [>420.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
  TRY 1 SLOW [>480.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [>480.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [>480.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [>480.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
  TRY 1 SLOW [>540.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [>540.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [>540.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [>540.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
  TRY 1 SLOW [>600.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [>600.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [>600.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [>600.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
  TRY 1 SLOW [>660.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
  TRY 1 SLOW [>660.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
  TRY 1 SLOW [>660.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
  TRY 1 SLOW [>660.000s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
     Running [ 00:11:12] [                                                                                                                                                   ]   0/14 : 4 running, 0 passed, 37 skipped        Canceling due to interrupt: 4 tests still running
      SIGINT [ 672.619s] integration-tests::wallet_to_validator wallet_basic::zcashd_connect_to_node_get_info
      SIGINT [ 672.624s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_orchard
      SIGINT [ 672.631s] integration-tests::wallet_to_validator wallet_basic::zcashd_monitor_unverified_mempool
      SIGINT [ 672.633s] integration-tests::wallet_to_validator wallet_basic::zcashd_send_to_all
------------
     Summary [ 672.634s] 4/14 tests run: 0 passed, 4 failed, 37 skipped
     ```

@idky137 idky137 merged commit 0fdc560 into zingolabs:dev Feb 27, 2025
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants