Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Get block range nullifiers #86

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

idky137
Copy link
Contributor

@idky137 idky137 commented Oct 30, 2024

Implements the get_block_range_nullifers gRPC service.

Currently there are no tests for this in Zaino, these will be added when the last PRs for [https://github.com/zingolabs/zcash-local-net] land and we can integrate that repo into Zaino-testutils. There is a test in [https://github.com/zingolabs/zcash-local-net] that tests this function "integrations::get_block_range_nullifiers".

@idky137 idky137 requested a review from Oscar-Pepper October 30, 2024 11:54
@idky137 idky137 added the ZGM1 Issues that need to be resolved for the completion of the Zaino dev grant milestone 1 label Oct 30, 2024
@idky137 idky137 marked this pull request as ready for review October 30, 2024 11:54
@idky137 idky137 mentioned this pull request Oct 30, 2024
Copy link
Contributor

@Oscar-Pepper Oscar-Pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im concerned an unchecked cast from u64 to u32 could cause undefined overflow behaviour etc.

@Oscar-Pepper Oscar-Pepper merged commit 4fc17be into zingolabs:dev Nov 1, 2024
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZGM1 Issues that need to be resolved for the completion of the Zaino dev grant milestone 1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants