Owls a.1

zingolib/src/config.rs

@@ -30,10 +30,12 @@ use zcash_primitives::consensus::{
 /// TODO: Add Doc Comment Here!
 pub const DEVELOPER_DONATION_ADDRESS: &str = "u1w47nzy4z5g9zvm4h2s4ztpl8vrdmlclqz5sz02742zs5j3tz232u4safvv9kplg7g06wpk5fx0k0rx3r9gg4qk6nkg4c0ey57l0dyxtatqf8403xat7vyge7mmen7zwjcgvryg22khtg3327s6mqqkxnpwlnrt27kxhwg37qys2kpn2d2jl2zkk44l7j7hq9az82594u3qaescr3c9v";
 /// TODO: Add Doc Comment Here!
-pub const ZENNIES_FOR_ZINGO_DONATION_ADDRESS: &str = "u1p32nu0pgev5cr0u6t4ja9lcn29kaw37xch8nyglwvp7grl07f72c46hxvw0u3q58ks43ntg324fmulc2xqf4xl3pv42s232m25vaukp05s6av9z76s3evsstax4u6f5g7tql5yqwuks9t4ef6vdayfmrsymenqtshgxzj59hdydzygesqa7pdpw463hu7afqf4an29m69kfasdwr494";
-/// TODO: Add Doc Comment Here!
 pub const ZENNIES_FOR_ZINGO_REGTEST_ADDRESS: &str = "uregtest14emvr2anyul683p43d0ck55c04r65ld6f0shetcn77z8j7m64hm4ku3wguf60s75f0g3s7r7g89z22f3ff5tsfgr45efj4pe2gyg5krqp5vvl3afu0280zp9ru2379zat5y6nkqkwjxsvpq5900kchcgzaw8v8z3ggt5yymnuj9hymtv3p533fcrk2wnj48g5vg42vle08c2xtanq0e";
 /// TODO: Add Doc Comment Here!
+pub const ZENNIES_FOR_ZINGO_TESTNET_ADDRESS: &str = "utest19zd9laj93deq4lkay48xcfyh0tjec786x6yrng38fp6zusgm0c84h3el99fngh8eks4kxv020r2h2njku6pf69anpqmjq5c3suzcjtlyhvpse0aqje09la48xk6a2cnm822s2yhuzfr47pp4dla9rakdk90g0cee070z57d3trqk87wwj4swz6uf6ts6p5z6lep3xyvueuvt7392tww";
+/// TODO: Add Doc Comment Here!
+pub const ZENNIES_FOR_ZINGO_DONATION_ADDRESS: &str = "u1p32nu0pgev5cr0u6t4ja9lcn29kaw37xch8nyglwvp7grl07f72c46hxvw0u3q58ks43ntg324fmulc2xqf4xl3pv42s232m25vaukp05s6av9z76s3evsstax4u6f5g7tql5yqwuks9t4ef6vdayfmrsymenqtshgxzj59hdydzygesqa7pdpw463hu7afqf4an29m69kfasdwr494";
+/// TODO: Add Doc Comment Here!
 pub const ZENNIES_FOR_ZINGO_AMOUNT: u64 = 1_000_000;
 /// TODO: Add Doc Comment Here!
 pub const DEFAULT_LIGHTWALLETD_SERVER: &str = "https://zec.rocks:443";

zingolib/src/lightclient/describe.rs

@@ -98,7 +98,7 @@ impl LightClient {
             spendable_orchard_balance,
             unverified_orchard_balance,
 
-            transparent_balance: self.wallet.tbalance().await,
+            transparent_balance: self.wallet.get_transparent_balance().await,
         }
     }
 

zingolib/src/lightclient/send.rs

@@ -247,9 +247,19 @@ pub mod send_with_proposal {
 
     #[cfg(all(test, feature = "testvectors"))]
     mod tests {
+        use crate::{
+            lightclient::LightClient,
+            wallet::{
+                disk::testing::examples::{
+                    ExampleMSKMGDBHOTBPETCJWCSPGOPPWalletVersion, ExampleTestnetWalletSeed,
+                    ExampleWalletNetwork,
+                },
+                LightWallet,
+            },
+        };
 
         #[tokio::test]
-        async fn complete_and_broadcast() {
+        async fn complete_and_broadcast_unconnected_error() {
             use crate::{
                 config::ZingoConfigBuilder,
                 lightclient::{send::send_with_proposal::CompleteAndBroadcastError, LightClient},
@@ -275,5 +285,18 @@ pub mod send_with_proposal {
                     .to_string(),
             );
         }
+
+        #[ignore]
+        #[tokio::test]
+        async fn sync_testnet() {
+            let wallet = LightWallet::load_example_wallet(ExampleWalletNetwork::Testnet(
+                ExampleTestnetWalletSeed::MSKMGDBHOTBPETCJWCSPGOPP(
+                    ExampleMSKMGDBHOTBPETCJWCSPGOPPWalletVersion::Gab72a38b,
+                ),
+            ))
+            .await;
+            let lc = LightClient::create_from_wallet_async(wallet).await.unwrap();
+            let _ = lc.do_sync(true).await;
+        }
     }
 }

zingolib/src/wallet/describe.rs

@@ -38,9 +38,11 @@ impl LightWallet {
     }
     // Core shielded_balance function, other public methods dispatch specific sets of filters to this
     // method for processing.
-    // This methods ensures that None is returned in the case of a missing view capability
+    /// Returns the sum of unspent notes recorded by the wallet
+    /// with optional filtering.
+    /// This method ensures that None is returned in the case of a missing view capability.
     #[allow(clippy::type_complexity)]
-    async fn get_filtered_balance<D>(
+    pub async fn get_filtered_balance<D>(
         &self,
         filter_function: Box<dyn Fn(&&D::WalletNote, &TransactionRecord) -> bool + '_>,
     ) -> Option<u64>
@@ -102,7 +104,7 @@ impl LightWallet {
         }
     }
     /// Sums the transparent balance (unspent)
-    pub async fn tbalance(&self) -> Option<u64> {
+    pub async fn get_transparent_balance(&self) -> Option<u64> {
         if self.wallet_capability().transparent.can_view() {
             Some(
                 self.get_utxos()

zingolib/src/wallet/disk/testing.rs

@@ -51,3 +51,76 @@ pub mod examples;
 /// tests
 #[cfg(test)]
 pub mod tests;
+
+// test helper functions
+
+/// asserts that a fresh capability generated with the seed matches the extant capability, which also can export the seed
+pub async fn assert_wallet_capability_matches_seed(
+    wallet: &LightWallet,
+    expected_seed_phrase: String,
+) {
+    let actual_seed_phrase = wallet.get_seed_phrase().await.unwrap();
+    assert_eq!(expected_seed_phrase, actual_seed_phrase);
+
+    let expected_mnemonic = (
+        zcash_primitives::zip339::Mnemonic::from_phrase(expected_seed_phrase).unwrap(),
+        0,
+    );
+    assert_eq!(wallet.mnemonic(), Some(&expected_mnemonic));
+
+    let expected_wc = crate::wallet::keys::unified::WalletCapability::new_from_phrase(
+        &wallet.transaction_context.config,
+        &expected_mnemonic.0,
+        expected_mnemonic.1,
+    )
+    .unwrap();
+    let wc = wallet.wallet_capability();
+
+    // We don't want the WalletCapability to impl. `Eq` (because it stores secret keys)
+    // so we have to compare each component instead
+
+    // Compare Orchard
+    let crate::wallet::keys::unified::Capability::Spend(orchard_sk) = &wc.orchard else {
+        panic!("Expected Orchard Spending Key");
+    };
+    assert_eq!(
+        orchard_sk.to_bytes(),
+        orchard::keys::SpendingKey::try_from(&expected_wc)
+            .unwrap()
+            .to_bytes()
+    );
+
+    // Compare Sapling
+    let crate::wallet::keys::unified::Capability::Spend(sapling_sk) = &wc.sapling else {
+        panic!("Expected Sapling Spending Key");
+    };
+    assert_eq!(
+        sapling_sk,
+        &zcash_client_backend::keys::sapling::ExtendedSpendingKey::try_from(&expected_wc).unwrap()
+    );
+
+    // Compare transparent
+    let crate::wallet::keys::unified::Capability::Spend(transparent_sk) = &wc.transparent else {
+        panic!("Expected transparent extended private key");
+    };
+    assert_eq!(
+        transparent_sk,
+        &crate::wallet::keys::extended_transparent::ExtendedPrivKey::try_from(&expected_wc)
+            .unwrap()
+    );
+}
+
+/// basically does what it says on the tin
+pub async fn assert_wallet_capability_contains_n_triple_pool_receivers(
+    wallet: &LightWallet,
+    expected_num_addresses: usize,
+) {
+    let wc = wallet.wallet_capability();
+
+    assert_eq!(wc.addresses().len(), expected_num_addresses);
+    for addr in wc.addresses().iter() {
+        assert!(addr.orchard().is_some());
+        assert!(addr.sapling().is_some());
+        assert!(addr.transparent().is_some());
+    }
+}

zingolib/src/wallet/disk/testing/examples.rs

@@ -42,6 +42,8 @@ pub enum ExampleTestnetWalletSeed {
 pub enum ExampleMSKMGDBHOTBPETCJWCSPGOPPWalletVersion {
     /// wallet was last saved by the code in this commit
     Gab72a38b,
+    /// this wallet was synced in this version. does it have a bunch of taz scattered around different addresses?
+    G93738061a,
 }
 /// A testnet wallet initiated with
 /// --seed "chimney better bulb horror rebuild whisper improve intact letter giraffe brave rib appear bulk aim burst snap salt hill sad merge tennis phrase raise"
@@ -112,6 +114,14 @@ impl LightWallet {
                 ))
                 .await
             }
+            ExampleWalletNetwork::Testnet(ExampleTestnetWalletSeed::MSKMGDBHOTBPETCJWCSPGOPP(
+                ExampleMSKMGDBHOTBPETCJWCSPGOPPWalletVersion::G93738061a,
+            )) => {
+                LightWallet::unsafe_from_buffer_testnet(include_bytes!(
+                    "examples/testnet/mskmgdbhotbpetcjwcspgopp/G93738061a/zingo-wallet.dat"
+                ))
+                .await
+            }
             ExampleWalletNetwork::Testnet(ExampleTestnetWalletSeed::CBBHRWIILGBRABABSSHSMTPR(
                 ExampleCBBHRWIILGBRABABSSHSMTPRWalletVersion::V26,
             )) => {