Main bc owl mainnet 3 #1478

fluidvanadium · 2024-10-28T20:23:51Z

(optional) to update the hot wallet in order to minimize execution time:

cargo run -- --data-dir zingolib/src/wallet/disk/testing/examples/mainnet/hhcclaltpcckcsslpcnetblr/latest/

to run a basic hot test:

cargo nextest run --run-ignored=all mainnet_latest_send_to_self_orchard_hot

test only PR

mainnet tests
separated assert_fee_and_record into helpers
numerous micro refactors

…_owl_mainnet

now if the todo_name function panics, it will be in a more informative place.

removed chain argument from transaction_request_from_send_inputs and associated functions. there are expectations to fix here

$cargo nextest run lr_shield_hot --no-capture --run-ignored only Compiling zingolib v0.2.0 (/home/cupress/ZINGO/libs/main_bc_owl_mainnet/zingolib) Compiling darkside-tests v0.1.0 (/home/cupress/ZINGO/libs/main_bc_owl_mainnet/darkside-tests) Compiling zingo-cli v0.2.0 (/home/cupress/ZINGO/libs/main_bc_owl_mainnet/zingocli) Compiling libtonode-tests v0.2.0 (/home/cupress/ZINGO/libs/main_bc_owl_mainnet/libtonode-tests) Finished `test` profile [optimized] target(s) in 38.13s ------------ Nextest run ID d27d20f6-3a6d-4c9e-bd22-f403376c08aa with nextest profile: default Starting 1 test across 18 binaries (344 tests skipped) START zingolib lightclient::send::send_with_proposal::test::mainnet_hhcclaltpcckcsslpcnetblr_shield_hot running 1 test **Batch** Current: 2 Total: 13 **Blocks** Current Height: 2665069 **Batch** Current: 5 Total: 13 **Blocks** Current Height: 2665369 **Batch** Current: 9 Total: 13 **Blocks** Current Height: 2665769 **Batch** Current: 12 Total: 13 **Blocks** Current Height: 2666010 PoolBalances { sapling_balance: Some(0), verified_sapling_balance: Some(0), spendable_sapling_balance: Some(0), unverified_sapling_balance: Some(0), orchard_balance: Some(635000), verified_orchard_balance: Some(635000), unverified_orchard_balance: Some(0), spendable_orchard_balance : Some(635000), transparent_balance: Some(100000) } mainnet_hhcclaltpcckcsslpcnetblr has 21 transactions in it SLOW [> 60.000s] zingolib lightclient::send::send_with_proposal::test::mainnet_hhcclaltpcckcsslpcnetblr_shield_hot test lightclient::send::send_with_proposal::test::mainnet_hhcclaltpcckcsslpcnetblr_shield_hot has been running for over 60 seconds SLOW [>120.000s] zingolib lightclient::send::send_with_proposal::test::mainnet_hhcclaltpcckcsslpcnetblr_shield_hot test lightclient::send::send_with_proposal::test::mainnet_hhcclaltpcckcsslpcnetblr_shield_hot ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 213 filtered out; finished in 168.26s PASS [ 168.265s] zingolib lightclient::send::send_with_proposal::test::mainnet_hhcclaltpcckcsslpcnetblr_shield_hot ------------ Summary [ 168.265s] 1 test run: 1 passed (1 slow), 344 skipped 1727809469 || mbompp_fix_shield[ ] cb3c83e so shielding works on dev in the single-address case $cargo nextest run pr_shield_hot --no-capture --run-ignored only Finished `test` profile [optimized] target(s) in 0.14s ------------ Nextest run ID 914799ea-9e23-423e-b4d1-a44d97884768 with nextest profile: default Starting 1 test across 18 binaries (344 tests skipped) START zingolib lightclient::send::send_with_proposal::test::testnet_cbbhrwiilgbrababsshsmtpr_shield_hot running 1 test **Batch** Current: 8 Total: 17 **Blocks** Current Height: 3000848 **Batch** Current: 16 Total: 17 **Blocks** Current Height: 3001600 PoolBalances { sapling_balance: Some(0), verified_sapling_balance: Some(0), spendable_sapling_balance: Some(0), unverified_sapling_balance: Some(0), orchard_balance: Some(2022), verified_orchard_balance: Some(2022), unverified_orchard_balance: Some(0 ), spendable_orchard_balance: Some(2022), transparent_balance: Some(2212000) } thread 'lightclient::send::send_with_proposal::test::testnet_cbbhrwiilgbrababsshsmtpr_shield_hot' panicked at zingolib/src/testutils/chain_generics/with_assertions.rs:172:6: record is ok: Mismatch(Transmitted(BlockHeight(3001601)), Transmitted(BlockHeight(3001601)), Err(FeeUnderflow { input_value: 2212000, explicit_output_value: 5441000 }), 1195000) stack backtrace: 0: rust_begin_unwind 1: core::panicking::panic_fmt 2: core::result::unwrap_failed 3: zingolib::testutils::chain_generics::with_assertions::propose_shield_bump_sync::{{closure}} 4: zingolib::lightclient::send::send_with_proposal::test::testnet_cbbhrwiilgbrababsshsmtpr_shield_hot::{{closure}} 5: tokio::runtime::scheduler::current_thread::Context::enter 6: tokio::runtime::context::scoped::Scoped<T>::set 7: tokio::runtime::scheduler::current_thread::CoreGuard::block_on 8: tokio::runtime::context::runtime::enter_runtime 9: tokio::runtime::runtime::Runtime::block_on 10: zingolib::lightclient::send::send_with_proposal::test::testnet_cbbhrwiilgbrababsshsmtpr_shield_hot 11: core::ops::function::FnOnce::call_once note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. test lightclient::send::send_with_proposal::test::testnet_cbbhrwiilgbrababsshsmtpr_shield_hot ... FAILED failures: failures: lightclient::send::send_with_proposal::test::testnet_cbbhrwiilgbrababsshsmtpr_shield_hot test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 213 filtered out; finished in 9.94s FAIL [ 9.942s] zingolib lightclient::send::send_with_proposal::test::testnet_cbbhrwiilgbrababsshsmtpr_shield_hot ------------ Summary [ 9.942s] 1 test run: 0 passed, 1 failed, 344 skipped FAIL [ 9.942s] zingolib lightclient::send::send_with_proposal::test::testnet_cbbhrwiilgbrababsshsmtpr_shield_hot error: test run failed 1727800954 || main_bc_owl_mainnet_plus_provider[ ] c58987fbb

…_provider

zancas

Please change from initial letter on each token of the seed phrase to the initial tokens in the seed.. maybe 2 or 3.

Please use the default import syntax that code actions enforce on files.

fluidvanadium · 2024-10-29T17:34:06Z

Please change from initial letter on each token of the seed phrase to the initial tokens in the seed.. maybe 2 or 3.

Please use the default import syntax that code actions enforce on files.

not within the scope of this PR

zancas · 2024-10-30T03:04:08Z

Please change from initial letter on each token of the seed phrase to the initial tokens in the seed.. maybe 2 or 3.
Please use the default import syntax that code actions enforce on files.

not within the scope of this PR

Yeah, I am fine with these issues being addressed in another PR. That could be a cleaner flow.

zingolib/src/testutils/lightclient.rs

zingolib/src/testutils/assertions.rs

We can address in a separate PR.

fluidvanadium added 30 commits September 23, 2024 23:13

new mainnet example wallet

29a0865

Merge branch 'main_bc_owl_base_addresses' into main_bc_owl_mainnet

79f3c7d

simplify parameters in transaction_request_from_send_inputs

84b026f

Merge branch 'transaction_request_from_inputs_and_chain' into main_bc…

260f811

…_owl_mainnet

propose from sapling test

0afde08

ignored test

d0c9b13

edits

1e57f56

mainnet_hhcclaltpcckcsslpcnetblr_send_to_self_orchard_hot

7719964

Merge branch 'wallet_base_address' into main_bc_owl_mainnet

d7eaeec

Merge branch 'wallet_base_address' into main_bc_owl_mainnet

7d6d481

Merge branch 'wallet_base_address' into main_bc_owl_mainnet

3ca693a

ignored test because running it in CI was always an insane idea

1185198

upgraded comments

cd2d258

edit

abbecf4

added sapling and transparent test cases

c2bc3d2

set amounts to more than fee

253f6aa

identifier change to clarify a function

c4fd724

changed return type on assertively_lookup_fee

3091ede

fixed callsites of assertively_lookup_fee

19b23b8

now if the todo_name function panics, it will be in a more informative place.

created hhcc____ wallet version Latest

d1d8358

add comment

7d929b9

Merge remote-tracking branch 'labs/dev' into main_bc_owl_mainnet_2

a71d85c

removed chain argument from transaction_request_from_send_inputs and associated functions. there are expectations to fix here

cargo clippy --fix --tests --all-features

8a7cb61

cargo fmt

e131057

modify doc comment

3e5e4ce

modify doc comment

c4fc881

modify doc comment

18b65d3

moved crypto provider

6550cab

Merge remote-tracking branch 'labs/dev' into main_bc_owl_mainnet_plus…

29e77a2

…_provider

fluidvanadium added 6 commits October 29, 2024 15:27

use crate::wallet::disk::testing::examples

01d58db

use crate::wallet::disk::testing::examples

9d0c73d

add comment

942beb6

remove bash

114f20b

finished examples.rs more explicit match level

013f48c

ignore test

5457fbc

fluidvanadium force-pushed the main_bc_owl_mainnet_3 branch from 5a5858c to 5457fbc Compare October 29, 2024 16:13

fluidvanadium added 5 commits October 29, 2024 16:15

remove log from netutils

51f6b3a

delete instruction doc

bc4c7b1

helperized ring and doc-comment for sync_example_wallet

25ad99a

identifier change

2fc07ef

identifier changes

e55bb50

fluidvanadium force-pushed the main_bc_owl_mainnet_3 branch from 41d43d7 to e55bb50 Compare October 29, 2024 16:34

zancas previously requested changes Oct 29, 2024

View reviewed changes

fluidvanadium unassigned zancas Oct 29, 2024

fluidvanadium requested a review from idky137 October 29, 2024 17:23

fluidvanadium assigned AloeareV, Oscar-Pepper and idky137 Oct 29, 2024

pithier testnames

c13a0c4

AloeareV previously approved these changes Oct 30, 2024

View reviewed changes

zingolib/src/testutils/lightclient.rs Show resolved Hide resolved

zingolib/src/testutils/assertions.rs Show resolved Hide resolved

zancas dismissed AloeareV’s stale review via 860958a October 30, 2024 21:30

Merge remote-tracking branch 'labs/dev' into main_bc_owl_mainnet_3

3063d33

fluidvanadium force-pushed the main_bc_owl_mainnet_3 branch from 860958a to 3063d33 Compare October 30, 2024 21:42

fixed name based on feedback

0af4eb1

fluidvanadium added the test label Oct 30, 2024

zancas merged commit 705cff2 into zingolabs:dev Oct 30, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Main bc owl mainnet 3 #1478

Main bc owl mainnet 3 #1478

fluidvanadium commented Oct 28, 2024 •

edited

Loading

zancas left a comment

fluidvanadium commented Oct 29, 2024

zancas commented Oct 30, 2024

Main bc owl mainnet 3 #1478

Main bc owl mainnet 3 #1478

Conversation

fluidvanadium commented Oct 28, 2024 • edited Loading

zancas left a comment

Choose a reason for hiding this comment

fluidvanadium commented Oct 29, 2024

zancas commented Oct 30, 2024

fluidvanadium commented Oct 28, 2024 •

edited

Loading