Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore order for value_transfers and messages #1525

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Restore order for value_transfers and messages #1525

merged 6 commits into from
Nov 18, 2024

Conversation

dorianvp
Copy link
Member

This PR fixes value_transfers and messages_containing, as they had the inverse order... sorry @juanky201271. It also adds more assertions.

@dorianvp dorianvp requested review from AloeareV and zancas November 16, 2024 00:27
zancas
zancas previously approved these changes Nov 16, 2024
View reviewed changes
@zancas zancas requested review from juanky201271 and removed request for AloeareV November 16, 2024 00:30
@zancas zancas marked this pull request as draft November 16, 2024 00:51
@zancas
Copy link
Member

zancas commented Nov 16, 2024

Looks like we need to check the full test suite for regressions.

juanky201271
juanky201271 previously approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@juanky201271 juanky201271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, looks good to me...

@dorianvp dorianvp dismissed stale reviews from juanky201271 and zancas via 6e059ce November 16, 2024 02:09
@dorianvp dorianvp marked this pull request as ready for review November 16, 2024 02:24
zancas
zancas requested changes Nov 16, 2024
View reviewed changes
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's document a Comprehensive Test Run, against this feature.

@dorianvp
Copy link
Member Author

dorianvp commented Nov 17, 2024 •
edited
Loading 

------------
     Summary [ 788.514s] 334 tests run: 334 passed (109 slow), 30 skipped

git show -s
commit 994103544b2385b9ef4c8f12a5ca4ad4247a8b43 (HEAD, dorian/fix-vt-message-order)
Author: dorianvp <dariovp01@gmail.com>
Date:   Sun Nov 17 14:40:26 2024 -0300

    test: add doc & remove println

@dorianvp dorianvp requested a review from zancas November 17, 2024 18:56
@zancas zancas merged commit cceca3e into zingolabs:dev Nov 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AloeareV AloeareV AloeareV approved these changes

@zancas zancas zancas approved these changes

@juanky201271 juanky201271 juanky201271 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dorianvp @zancas @juanky201271 @AloeareV