Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse empty uri strings correctly in load_clientconfig #1584

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

dorianvp
Copy link
Member

@dorianvp dorianvp commented Dec 9, 2024

This PR makes construct_lightwalletd_uri accept empty String for the server argument.

@dorianvp dorianvp self-assigned this Dec 9, 2024
@dorianvp
Copy link
Member Author

dorianvp commented Dec 9, 2024

Running a CLT...

@dorianvp dorianvp marked this pull request as ready for review December 9, 2024 17:59
@dorianvp
Copy link
Member Author

dorianvp commented Dec 9, 2024

The CLT suite passed!

Copy link
Contributor

@juanky201271 juanky201271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice!
related with: #1557

@dorianvp dorianvp merged commit f51c7f3 into zingolabs:dev Dec 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants