Adding Fee Calculation Tests #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ive removed the feature gate for fee calculation and commented out zip317 expected_fee, it seams that CI runs tests with all features enabled so these tests wont pass. When zip317 lands these tests will fail. The current expected_fee will need to be removed and zip317 expected_fee will need to be un-commented, but no new code needs to be written. Ive added comments to show this. Should now be ready to merge. change made in [8719fad] |
Oscar-Pepper
requested changes
Apr 11, 2024
fluidvanadium
approved these changes
Apr 12, 2024
Oscar-Pepper
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for fee calculation.