Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extracted mod witness_trees #931

Merged
merged 2 commits into from
Apr 11, 2024
Merged

extracted mod witness_trees #931

merged 2 commits into from
Apr 11, 2024

Conversation

fluidvanadium
Copy link
Contributor

This is a refactor change.

@zancas
Copy link
Member

zancas commented Apr 11, 2024

I think the mod.rs pattern is the old way of doing things. I prefer not to have any file named mod.rs.

zancas
zancas requested changes Apr 11, 2024
View reviewed changes
zingolib/src/data/mod.rs Outdated Show resolved Hide resolved
@fluidvanadium fluidvanadium requested a review from zancas April 11, 2024 02:20
@fluidvanadium fluidvanadium changed the title moved data.rs in favour of data/mod.rs and extracted mod witness_trees extracted mod witness_trees Apr 11, 2024
@zancas zancas merged commit 707e199 into zingolabs:dev Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zancas zancas zancas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluidvanadium @zancas