-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle client idle timeout to prevent abundant logging #2373
Comments
/bounty $50 |
💎 $50 bounty created by ZIO
|
/attempt #2373 Options |
1 similar comment
/attempt #2373 Options |
Note: The user @Mayhul-Jindal is already attempting to complete issue #2373 and claim the bounty. If you attempt to complete the same issue, there is a chance that @Mayhul-Jindal will complete the issue first, and be awarded the bounty. We recommend discussing with @Mayhul-Jindal and potentially collaborating on the same solution versus creating an alternate solution. |
Whenever a ReadTimeoutException is thrown, the specific handling code within the case match will be executed. For now, I've left it to do nothing (i.e., it'll just swallow the exception). If you'd like to handle it in some other manner, like logging it at a different severity or executing some custom logic, replace the comment with the appropriate code.
@Mayhul-Jindal: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
@joshuallopez: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
The bounty is up for grabs! Everyone is welcome to |
/attempt #2373 Options |
@an0nym3sh: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
The bounty is up for grabs! Everyone is welcome to |
/attempt #2373 Options |
@sanjulaonline: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
The bounty is up for grabs! Everyone is welcome to |
The bounty is up for grabs! Everyone is welcome to |
/attempt #2373 Options |
💡 @ekhov submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
On idle timeout for NettyConnectionPool handle ReadTimeoutExceptions- just log them with debug level, so they don't propagate as unhandled errors further
🎉🎈 @ekhov has been awarded $50! 🎈🎊 |
Applications that use the http client keep seeing logging every few minutes (using version 3.0.0-RC2+45-e3636f00-SNAPSHOT):
They always comes in groups of 10 with just a few ms between them. There is never a request going on at that time. According to @vigoo the groups of 10 means that all connections in the connection pool time out at the same time (it has a default size of 10).
I would prefer not to have these warnings logged.
Of course, these warning could be suppressed using the logging framework, but handling this in zio-http gives a better developer experience for all users.
@vigoo suggests to handle the timeout so it does not get logged. Probably in the client inbound handler.
See Discord discussion.
The text was updated successfully, but these errors were encountered: