Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal usage of warning header #2955

Closed
987Nabil opened this issue Jul 9, 2024 · 4 comments · Fixed by #3050
Closed

Remove internal usage of warning header #2955

987Nabil opened this issue Jul 9, 2024 · 4 comments · Fixed by #3050
Labels

Comments

@987Nabil
Copy link
Contributor

987Nabil commented Jul 9, 2024

The warning header is currently used by zio-http. But is deprecated. I think errors should not add any info about stack traces or error messages in headers at all.
We should have error messages as opt-in in the body.
This should be a setting that can be set globally by a config, as well as by the user for a specific call to Response.error and similar methods.

@987Nabil 987Nabil added the enhancement New feature or request label Jul 9, 2024
@jdegoes
Copy link
Member

jdegoes commented Jul 30, 2024

/bounty $300 to remove warning headers and to have opt-in error messages in body.

Copy link

algora-pbc bot commented Jul 30, 2024

💎 $300 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #2955 with your implementation plan
  2. Submit work: Create a pull request including /claim #2955 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-http!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @987Nabil #3050

Copy link

algora-pbc bot commented Aug 23, 2024

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

987Nabil added a commit to 987Nabil/zio-http that referenced this issue Aug 27, 2024

Verified

This commit was signed with the committer’s verified signature.
987Nabil Nabil Abdel-Hafeez
987Nabil added a commit that referenced this issue Aug 27, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

algora-pbc bot commented Aug 27, 2024

🎉🎈 @987Nabil has been awarded $300! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants