Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify naming for configs #3081

Closed
987Nabil opened this issue Sep 2, 2024 · 8 comments · Fixed by #3105
Closed

Unify naming for configs #3081

987Nabil opened this issue Sep 2, 2024 · 8 comments · Fixed by #3105
Labels

Comments

@987Nabil
Copy link
Contributor

987Nabil commented Sep 2, 2024

Currently some config leaves are kebab-case and some are camelCase.

I see three options

  1. All kebab
  2. All camel
  3. Be agnostic and accept both (I think I'd prefer this one)
@987Nabil 987Nabil added the enhancement New feature or request label Sep 2, 2024
@kyri-petrou
Copy link
Collaborator

kyri-petrou commented Sep 2, 2024

I think we should stick with (1) since it's also compatible with bash naming OOTB and perhaps add support for fallback to camelCase in ZIO directly

@987Nabil
Copy link
Contributor Author

987Nabil commented Sep 2, 2024

I am fine with doing it in zio directly, but I think it is okay to be graceful

@jdegoes
Copy link
Member

jdegoes commented Sep 3, 2024

/bounty $50

Copy link

algora-pbc bot commented Sep 3, 2024

💎 $50 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #3081 with your implementation plan
  2. Submit work: Create a pull request including /claim #3081 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-http!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @mh-lamine Sep 4, 2024, 7:01:13 AM WIP
🟢 @987Nabil #3105

@mh-lamine
Copy link

mh-lamine commented Sep 4, 2024

/attempt #3081

@987Nabil
Copy link
Contributor Author

987Nabil commented Sep 4, 2024

@mh-lamine we agreed on kebab-case for word spacing. Since this needs to be done asap, please open PR today.

Copy link

algora-pbc bot commented Sep 6, 2024

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Sep 6, 2024

🎉🎈 @987Nabil has been awarded $50! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants