Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming multipart/form-data #2062

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Streaming multipart/form-data #2062

merged 6 commits into from
Mar 27, 2023

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Mar 25, 2023

Resolves #2036

@vigoo vigoo marked this pull request as ready for review March 26, 2023 07:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.33 🎉

Comparison is base (6024ea0) 66.97% compared to head (853c258) 67.31%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2062      +/-   ##
==========================================
+ Coverage   66.97%   67.31%   +0.33%     
==========================================
  Files         140      141       +1     
  Lines        5705     5798      +93     
  Branches      220      239      +19     
==========================================
+ Hits         3821     3903      +82     
- Misses       1884     1895      +11     
Impacted Files Coverage Δ
zio-http/src/main/scala/zio/http/Body.scala 60.86% <0.00%> (-4.25%) ⬇️
...http/src/main/scala/zio/http/forms/FormState.scala 91.66% <66.66%> (-3.99%) ⬇️
zio-http/src/main/scala/zio/http/forms/Form.scala 76.38% <76.19%> (+0.67%) ⬆️
.../src/main/scala/zio/http/forms/StreamingForm.scala 90.32% <90.32%> (ø)
...o-http/src/main/scala/zio/http/forms/FormAST.scala 96.87% <100.00%> (+0.20%) ⬆️
...-http/src/main/scala/zio/http/forms/FormData.scala 90.00% <100.00%> (+4.28%) ⬆️
...http/src/main/scala/zio/http/netty/NettyBody.scala 80.00% <100.00%> (ø)
.../src/main/scala/zio/http/netty/NettyResponse.scala 100.00% <100.00%> (ø)
...a/zio/http/netty/server/ServerInboundHandler.scala 87.09% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: John A. De Goes <john@degoes.net>
@jdegoes
Copy link
Member

jdegoes commented Mar 27, 2023

@vigoo Build failure

@jdegoes jdegoes merged commit 633d862 into zio:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support streaming nature of multipart/form-data
3 participants