Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better drop trailing slash #2098

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Better drop trailing slash #2098

merged 2 commits into from
Apr 14, 2023

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Apr 14, 2023

Resolves #2094

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02 ⚠️

Comparison is base (256d94b) 67.15% compared to head (e3c378f) 67.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2098      +/-   ##
==========================================
- Coverage   67.15%   67.13%   -0.02%     
==========================================
  Files         141      141              
  Lines        5915     5916       +1     
  Branches      266      250      -16     
==========================================
  Hits         3972     3972              
- Misses       1943     1944       +1     
Impacted Files Coverage Δ
...src/main/scala/zio/http/HttpRouteMiddlewares.scala 66.66% <0.00%> (-33.34%) ⬇️
zio-http/src/main/scala/zio/http/Http.scala 63.04% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdegoes jdegoes merged commit 14eb1f2 into main Apr 14, 2023
@jdegoes jdegoes deleted the better-drop-trailing-slash branch April 14, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better support for routes with trailing slashes
3 participants