Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZClient fast shutdown #2410

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Conversation

johnhungerford
Copy link
Contributor

Added shutdownQuietPeriodDuration and shutdownTimeOutDuration to NettyConfig allowing users to customize the shutdown behavior of netty's EventLoopGroup.

Added defaultWithFastShutdown version of NettyConfig to be used by ClientConfig.default. Quiet period for this default is 50 ms and timeout is at 250 ms.

Added tests confirming that client cleanup takes no more than 250 ms and that a user can increase the quiet period.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 35.00% and project coverage change: +0.01% 🎉

Comparison is base (ca6513f) 63.41% compared to head (3fe2a23) 63.43%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2410      +/-   ##
==========================================
+ Coverage   63.41%   63.43%   +0.01%     
==========================================
  Files         137      137              
  Lines        7113     7116       +3     
  Branches     1259     1260       +1     
==========================================
+ Hits         4511     4514       +3     
  Misses       2602     2602              
Files Changed Coverage Δ
zio-http/src/main/scala/zio/http/ZClient.scala 42.75% <ø> (ø)
...rc/main/scala/zio/http/netty/EventLoopGroups.scala 33.33% <23.52%> (ø)
...tp/src/main/scala/zio/http/netty/NettyConfig.scala 60.00% <100.00%> (+17.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamgfraser adamgfraser merged commit 260cc73 into zio:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants