Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
shutdownQuietPeriodDuration
andshutdownTimeOutDuration
toNettyConfig
allowing users to customize the shutdown behavior of netty'sEventLoopGroup
.Added
defaultWithFastShutdown
version ofNettyConfig
to be used byClientConfig.default
. Quiet period for this default is 50 ms and timeout is at 250 ms.Added tests confirming that client cleanup takes no more than 250 ms and that a user can increase the quiet period.