Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Continue Reading From Web Socket After Terminal Event #2441

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Do Not Continue Reading From Web Socket After Terminal Event #2441

merged 2 commits into from
Sep 24, 2023

Conversation

adamgfraser
Copy link
Contributor

No description provided.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (8780eb9) 64.21% compared to head (cb03283) 64.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2441      +/-   ##
==========================================
- Coverage   64.21%   64.18%   -0.04%     
==========================================
  Files         136      136              
  Lines        7118     7119       +1     
  Branches     1302     1215      -87     
==========================================
- Hits         4571     4569       -2     
- Misses       2547     2550       +3     
Files Changed Coverage Δ
zio-http/src/main/scala/zio/http/Channel.scala 0.00% <0.00%> (-7.70%) ⬇️
...ttp/src/main/scala/zio/http/WebSocketChannel.scala 28.57% <ø> (-7.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frekw
Copy link
Contributor

frekw commented Sep 12, 2023

🙇 thanks @adamgfraser!

@jdegoes jdegoes merged commit 7489570 into zio:main Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants