Schema based ops for en- and decoding bodies #2569
Conversation
987Nabil
force-pushed
the
schema-based-body-ops
branch
from
6b2f76e to
ff1039f
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
=======================================
Coverage 64.23% 64.24%
=======================================
Files 140 140
Lines 8358 8357 -1
Branches 1604 1586 -18
=======================================
Hits 5369 5369
+ Misses 2989 2988 -1 ☔ View full report in Codecov by Sentry. |
987Nabil
requested review from
amitksingh1490,
jdegoes,
vigoo and
adamgfraser
as code owners
| * val decodedPerson = body.as[Person] | ||
| * }}} | ||
| */ | ||
| def as[A](implicit codec: BinaryCodec[A], trace: Trace): Task[A] = |
There was a problem hiding this comment.
Should this be to or into? as has a meaning in some ZIO contexts as map(_ => a).
There was a problem hiding this comment.
I chose the name because it is called queryAs if you want to get a typed query param
There was a problem hiding this comment.
Actually I am fine with both. I can change it next time a PC is in reach
There was a problem hiding this comment.
Maybe that should be queryTo or queryInto for consistency?
There was a problem hiding this comment.
Should it then also be body.toString and not body.asString? But this has an obvious conflict.
There was a problem hiding this comment.
Agreed, please update any other cases like this that you find.
| * val body = Body.from(person) | ||
| * }}} | ||
| */ | ||
| def from[A](a: A)(implicit codec: BinaryCodec[A], trace: Trace): Body = |
There was a problem hiding this comment.
The fact that this is called from almost does imply to or into.
987Nabil
force-pushed
the
schema-based-body-ops
branch
from
ff1039f to
ea9cc05
Compare
|
@jdegoes please take a look again. I changed too much to feel go to merge without an additional review |
Currently, we leave transforming data from and to bodies more or less to the user.
We only understand basic types like
StringorChunk[Byte].But since we have the endpoint API and a strong relationship with zio-schema, I think it makes sense, to have schema based operators, that can create and decode bodies.
This implementation is agnostic of the encoding (not json specific) and just requires an implicit
BinaryCodec.