feat: Add provide* combinators to Http and HttpResult #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frekw
requested review from
amitksingh1490,
dinojohn,
fenilkanjani,
pranjalnadhani,
ravisharnagat,
ShrutiVerma97 and
tusharmath
as code owners
frekw
changed the title
tusharmath
reviewed
Jun 16, 2021
tusharmath
reviewed
Jun 17, 2021
frekw
force-pushed
the
feat/provide-combinators
branch
2 times, most recently
from
7530e89 to
089a810
Compare
|
@tusharmath I updated this to be based on #265. I've removed However, as with the code in #265 we're still seeing exhaustivity warnings in Scala3 (that I believe are false) but am unsure how to work around them. Will ask around a bit on the Scala gitter. |
|
Could potentially be scala/scala3#9682 that we're running into. |
frekw
force-pushed
the
feat/provide-combinators
branch
from
53ef9c1 to
2418247
Compare
|
fixed in #364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on the work done in #189 and instead adds the
provide*combinators to theHttpResult.I also added all of the combinators to
Httpitself, just acting as wrappers on top.