Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middlewares to forward header and ensure the existence of a header #2808

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

987Nabil
Copy link
Contributor

No description provided.

@987Nabil 987Nabil requested review from jdegoes and vigoo as code owners April 26, 2024 23:30
@987Nabil
Copy link
Contributor Author

@jdegoes this PR has mainly microservice architecture in mind. But I am not sure about the header forwarding. This solution uses fiber refs, but it could be as well using Env and the context providing middleware. The trade off is, does one like the requirement of forwarded headers be explicit in the type or not? I am not sure what I prefer.

@jdegoes
Copy link
Member

jdegoes commented Aug 29, 2024

Hiding it would be better. Let me know when build is passing.

@jdegoes jdegoes merged commit 4087df4 into zio:main Sep 5, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants