Fix for routes with different parameter names #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
reviewed
Jun 12, 2024
| val matched = matches(index) | ||
| if (matched > 0) { | ||
| val (_, subtree0) = flattened(index) | ||
| val subpath = path.dropLeadingSlash.drop(i + matched) |
There was a problem hiding this comment.
Any way to eliminate these allocations?
There was a problem hiding this comment.
I think we can overload the get method to accept an index and use that as the starting i in this method. I'll open a separate PR
jdegoes
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #2728
/claim #2728
The solution to the linked issue is when we have multiple segment codecs that match the predicate, to evaluate them all by passing the partial path to their
getmethod, and find the one that returns a result.In order to avoid adding performance overhead, this evaluation is done only when we determined that we have ambiguities