Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verbosity of test suites #2979

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

kyri-petrou
Copy link
Collaborator

Currently the test suites print A LOT of stuff which is confusing and makes it difficult to track down errors. WIth this PR we reduce that verbosity by removing a lot of unnecessary debug / println statements, and by using the silent and silentLogging test aspects.

Note that I can't seem to manage to get rid of all of them, netty seems to be printing some warnings under the hood which I can't figure out a way to disable, e.g.,

WARNING: events[0]=[85, -1] had no channel!
July 26, 2024 12:38:21 PM io.netty.channel.kqueue.KQueueEventLoop processReady
WARNING: events[1]=[124, -1] had no channel!
July 26, 2024 12:38:21 PM io.netty.channel.kqueue.KQueueEventLoop processReady
WARNING: events[0]=[81, -1] had no channel!
July 26, 2024 12:38:21 PM io.netty.channel.kqueue.KQueueEventLoop processReady
WARNING: events[1]=[83, -1] had no channel!
July 26, 2024 12:38:21 PM io.netty.channel.kqueue.KQueueEventLoop processReady
WARNING: events[0]=[85, -1] had no channel!

If anyone has an idea on how to disable those as well that would be great!

@987Nabil 987Nabil merged commit 12f0c26 into zio:main Jul 28, 2024
34 checks passed
@kyri-petrou kyri-petrou deleted the reduce-test-suite-verbosity branch July 28, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants