Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3103 Only last response is generated into Endpoint code #3151

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

nafg
Copy link
Contributor

@nafg nafg commented Sep 18, 2024

/claim #3103

Copy link

algora-pbc bot commented Sep 18, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@nafg
Copy link
Contributor Author

nafg commented Sep 18, 2024

The issue was that the code was doing .collect { ... => ... (a, b) } on a Map, which returns another Map. But a is just the imports needed and may not be unique. Inserting a .toSeq fixed it.

@nafg nafg force-pushed the nafg/endpoint-only-last-response-used branch from e5ddea0 to cd5d260 Compare September 19, 2024 00:07
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.15%. Comparing base (f164c90) to head (cd5d260).
Report is 8 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
+ Coverage   65.09%   65.15%   +0.06%     
==========================================
  Files         161      161              
  Lines       10551    10561      +10     
  Branches     2024     2001      -23     
==========================================
+ Hits         6868     6881      +13     
+ Misses       3683     3680       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nafg
Copy link
Contributor Author

nafg commented Sep 19, 2024

Oh scala 2.12... :(

@nafg nafg force-pushed the nafg/endpoint-only-last-response-used branch from cd5d260 to cc415bf Compare September 19, 2024 00:36
@987Nabil 987Nabil merged commit 635603e into zio:main Sep 19, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants