added curl logger client aspect. #3285
Open
+123
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landlockedsurfer
requested review from
jdegoes,
vigoo,
kyri-petrou and
987Nabil
as code owners
Co-authored-by: Jules Ivanic <jivanic@demystdata.com>
Co-authored-by: Jules Ivanic <jivanic@demystdata.com>
guizmaii
reviewed
Jan 30, 2025
| )(implicit trace: Trace): ZClientAspect[Nothing, Any, Nothing, Body, Nothing, Any, Nothing, Response] = | ||
| new ZClientAspect[Nothing, Any, Nothing, Body, Nothing, Any, Nothing, Response] { | ||
|
|
||
| def formatCurlCommand( |
There was a problem hiding this comment.
@landlockedsurfer Do you think we could put this capacity to transform a Request to a curl String as a method of Request and use this method here?
That'd allow people to "toString" their requests in a nice way if they need to (to log it at any moment, for example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
There was a message in the Discord the other day asking for a curl command logger.
Here's a first version that should properly handle the most basic options. It does not handle any SSL options yet though.
I used the other
ZClientAspectinstances as a blueprint for the implementation.Hope this is useful!!