Implement and test pipeline/stream support for all platforms and scala versions #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fiddle around to see if the pipeline/stream decoding/encoding implementations would work on JS and Native platforms. It looks like it does! This PR make the current implementations and tests shared for all platforms.
This PR is just a draft to see how it can be implemented. One missing class on JS was
java.io.BufferedWriterbut it looks like the Native implementation of that class works fine. I included it in the PR but it can probably be contributed to Scala-js (I have no idea why it was not implemented there yet).