Skip to content

Commit

Permalink
Fix issue in "restartStreamsOnRebalancing mode closes all partition s…
Browse files Browse the repository at this point in the history
…treams" test relating to shutdown. This was also fixed in #591
  • Loading branch information
svroonland authored and guizmaii committed Mar 15, 2023
1 parent 1eb01d3 commit 1103431
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ private[consumer] final class Runloop(
s"onRevoked called on rebalance listener with pending assigned event"
)
)
}
}.unlessZIO(isShutdown).unit
}
}
)
Expand Down Expand Up @@ -512,7 +512,7 @@ private[consumer] final class Runloop(
case r @ Command.ChangeSubscription(_, _, _) =>
r.succeed.as(state)
case _ @Command.Commit(_, cont) =>
cont.fail(new KafkaException("Consumer is shutting down")).as(state)
cont.fail(new KafkaException("Consumer is shutting down")).as(state) // TODO can we just allow it?

}

Expand Down

0 comments on commit 1103431

Please sign in to comment.