Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative fetch strategy for many partitions #1281

Merged
merged 7 commits into from
Jul 16, 2024

Conversation

erikvanoosten
Copy link
Collaborator

When many hundreds of partitions need to be consumed, an excessive amount of heap can be used for pre-fetching. The ManyPartitionsQueueSizeBasedFetchStrategy works similarly as the default QueueSizeBasedFetchStrategy but limits total memory usage.

When many hundreds of partitions need to be consumed, an excessive amount of heap can be used for pre-fetching. The  `ManyPartitionsQueueSizeBasedFetchStrategy` works similarly as the default `QueueSizeBasedFetchStrategy` but limits total memory usage.
@erikvanoosten
Copy link
Collaborator Author

This ManyPartitionsQueueSizeBasedFetchStrategy has been run in production for a half a year now and works as expected. It was split of from #970.

Copy link
Collaborator

@svroonland svroonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice offering besides the existing fetch strategy.

@erikvanoosten erikvanoosten merged commit 7452812 into master Jul 16, 2024
14 checks passed
@erikvanoosten erikvanoosten deleted the many-partitions branch July 16, 2024 17:16
svroonland pushed a commit that referenced this pull request Aug 10, 2024
When many hundreds of partitions need to be consumed, an excessive
amount of heap can be used for pre-fetching. The
`ManyPartitionsQueueSizeBasedFetchStrategy` works similarly as the
default `QueueSizeBasedFetchStrategy` but limits total memory usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants