Improve Test Reliability by Replacing ZIO.sleep with Synchronization Primitives in ConsumerSpec #1401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1389
Description:
This pull request improves the reliability of tests in ConsumerSpec.scala by replacing the use of ZIO.sleep with synchronization primitives such as Promise and Ref. The previous implementation relied on arbitrary sleep durations to wait for certain conditions, which could lead to non-deterministic behavior and flakiness in the tests.
ZIO.sleep
to wait before starting the second consumer, which could cause timing-related flakiness.Ref[Set[Int]]
to track the partitions assigned to the first consumer and aPromise[Nothing, Unit]
to signal when the consumer has been assigned at least half of the partitions, replacing theZIO.sleep
.ZIO.sleep
to delay the start of the second consumer, leading to potential flakiness.Ref[Set[Int]]
and aPromise[Nothing, Unit]
to synchronize the start of the second consumer.ZIO.sleep
to wait before stopping the consumer.Ref[Int]
to count the number of messages consumed and aPromise[Nothing, Unit]
to signal when to stop consumption.