Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CircleCI #4

Merged
merged 1 commit into from
May 5, 2019
Merged

Setup CircleCI #4

merged 1 commit into from
May 5, 2019

Conversation

ghostdogpr
Copy link
Member

@ghostdogpr ghostdogpr commented May 5, 2019 •
edited
Loading

Closes #3

@ghostdogpr ghostdogpr requested a review from iravid May 5, 2019 01:30
iravid
iravid approved these changes May 5, 2019
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you! Does sbt-release-early support releasing snapshots for untagged commits in master?

@iravid iravid merged commit 6128e36 into zio:master May 5, 2019
@ghostdogpr
Copy link
Member Author

I disabled releases on master because it was creating a “real” release (not a snapshot), therefore polluting the list of versions in sonatype/maven. Another problem was that we could only have a single project in the org releasing at the same time: if we release for every commit to master, the chances of conflict are pretty high.

@iravid
Copy link
Member

iravid commented May 6, 2019

@ghostdogpr gotcha, thanks

@svroonland svroonland mentioned this pull request Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@iravid iravid iravid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup CI and publishing
3 participants
@ghostdogpr @iravid @NeQuissimus