-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LogAppender for java platform/system logger #493
Conversation
NOTE: |
ffc3dec
to
dce754a
Compare
dce754a
to
8d66e78
Compare
ZIO.logAnnotate(loggerNameKey, value)(zio) | ||
} | ||
|
||
def getLoggerName(default: String = "zio-jpl-logger"): Trace => String = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be hidden / made private.
): ZLayer[Any, Nothing, Unit] = | ||
jpl(format, getLoggerName()) | ||
|
||
def jpl: ZLayer[Any, Nothing, Unit] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a val
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor tweaks, and then good to merge!
@jdegoes - comments solved |
similar to
slf4j
backend implementationdefault behavior:
Trace
, addedJPL.loggerName
zio LogAnnotation for custom logger nameopen questions:
slf4j
and thisjpl
implementation got custom logger name aspect, should not we do common one?related to #322 (from this ticket it is not clear if this was requirement for backend implementation like slf4j or it should be something similar to slf4j-bridge)