Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve end-of-stream handling. #255

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Improve end-of-stream handling. #255

merged 5 commits into from
Oct 29, 2020

Conversation

quelgar
Copy link
Contributor

@quelgar quelgar commented Sep 15, 2020

As discussed in issue #247.

Copy link
Member

@mschuwalow mschuwalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 👍

@jdegoes
Copy link
Member

jdegoes commented Oct 21, 2020

@quelgar Conflicts?

quelgar and others added 2 commits October 22, 2020 07:00
As discussed in issue #247.
Improve wording.

Co-authored-by: Maxim Schuwalow <16665913+mschuwalow@users.noreply.github.com>
@quelgar
Copy link
Contributor Author

quelgar commented Oct 21, 2020

@jdegoes good to go

jczuchnowski
jczuchnowski previously approved these changes Oct 28, 2020
@jczuchnowski jczuchnowski merged commit a669d78 into master Oct 29, 2020
@jczuchnowski jczuchnowski deleted the quelgar/eof-handling branch October 29, 2020 17:43
svroonland pushed a commit that referenced this pull request Aug 9, 2021
* Improve end-of-stream handling.

As discussed in issue #247.

* Update docs/essentials/index.md.

Improve wording.

Co-authored-by: Maxim Schuwalow <16665913+mschuwalow@users.noreply.github.com>

* Update for latest master.

Co-authored-by: Maxim Schuwalow <16665913+mschuwalow@users.noreply.github.com>
Co-authored-by: Jakub Czuchnowski <jakub.czuchnowski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants