Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cross version for collection-compat #393

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

sviezypan
Copy link
Contributor

When trying to add Scala3 to zio-zmx this cross version modifier was causing problems since zio-nio brings 2_13 version of scala-collection-compat while zio-json brings scala-collection-compat_3.

@sviezypan sviezypan requested a review from a team as a code owner August 27, 2021 08:40
@svroonland svroonland merged commit 401de78 into zio:master Aug 27, 2021
@francisdb
Copy link
Contributor

Since releasing this is taking a long time I added an example workaround below:

httpclient-backend-zio has a transitive dependency on dev.zio:zio-nio-core_3:1.0.0-RC11 which causes:

[error] Modules were resolved with conflicting cross-version suffixes in ProjectRef(uri("file:/Users/me/myproj/"), "scala-integration-tests"):
[error]    org.scala-lang.modules:scala-collection-compat _3, _2.13
libraryDependencies ++= Seq(
  "com.softwaremill.sttp.client3" %% "httpclient-backend-zio" % "3.3.15" exclude("org.scala-lang.modules","scala-collection-compat_2.13")
  ..
)

@francisdb
Copy link
Contributor

Any reason this did not make it to 2.0.0-RC1?

[info]   | +-dev.zio:zio-nio_3:2.0.0-RC1
[info]   | | +-dev.zio:zio-streams_3:2.0.0-RC1
[info]   | | | +-org.scala-lang:scala3-library_3:3.1.0 (evicted by: 3.1.1)
[info]   | | |
[info]   | | +-dev.zio:zio_3:2.0.0-RC1
[info]   | | | +-org.scala-lang:scala3-library_3:3.1.0 (evicted by: 3.1.1)
[info]   | | |
[info]   | | +-org.scala-lang.modules:scala-collection-compat_2.13:2.6.0 [S]
[info]   | | +-org.scala-lang:scala3-library_3:3.1.0 (evicted by: 3.1.1)
[info]   | | +-org.scala-lang:scala3-library_3:3.1.1 [S]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants