Upgrade to ZIO 2.0 #450
Closed
Upgrade to ZIO 2.0 #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhrebicek
force-pushed
the
series/2.x
branch
from
4fe7823
to
b4ed18a
Compare
Closed
zhrebicek
force-pushed
the
series/2.x
branch
3 times, most recently
from
fd07825
to
b2cbc47
Compare
zhrebicek
force-pushed
the
series/2.x
branch
from
b2cbc47
to
2c0112e
Compare
zhrebicek
commented
Dec 17, 2021
| @@ -61,8 +61,10 @@ package object nio { | |||
| * The effect to run in a forked fiber. The resource is only valid within this effect. | |||
| */ | |||
| def useForked[R2 <: R, E2 >: E, B](f: A => ZIO[R2, E2, B]): ZIO[R2, E, Fiber[E2, B]] = | |||
| ReleaseMap.make.flatMap { releaseMap => | |||
| managed.zio.provideSome[R]((_, releaseMap)).flatMap { case (finalizer, a) => f(a).onExit(finalizer).fork } | |||
| ReleaseMap.make.flatMap { releaseMap => // TODO fix this | |||
There was a problem hiding this comment.
I am not sure with this as it throws this warning at me
warn] ──── ZLAYER WARNING ──────────────────────────────────────────────────
[warn]
[warn] You have provided more than is required.
[warn] You may remove the following layer:
[warn]
[warn] 1. ZLayer.succeed(releaseMap)(Tag(classOf[zio.ZManaged$$ReleaseMap], LightTypeTag.parse(-438314458, "\u0004\u0000\u0001\u0017zio.ZManaged.ReleaseMap\u0001\u0002\u0003\u0000\u0000\fzio.ZManaged\u0001\u0001", "\u0000\u0001\u0004\u0000\u0001\u0017zio.ZManaged.ReleaseMap\u0001\u0002\u0003\u0000\u0000\fzio.ZManaged\u0001\u0001\u0001\u0004\u0000\u0001\u0014java.io.Serializable\u0001\u0001\u0001\u0000\u0001\u0090\u0002\u0001\u0002\u0003\u0000\u0000\u0090\u0003\u0001\u0001\u0001\u0000\u0001\u0090\u0004\u0001\u0001", 11)), {
[warn] final class $anon extends _root_.zio.`package`.IsNotIntersection[zio.ZManaged.ReleaseMap];
[warn] new $anon()
[warn] }, "zio.nio.package.ManagedOps.useForked(package.scala:65)".asInstanceOf[_root_.zio.internal.stacktracer.Tracer.instance.Type with _root_.zio.internal.stacktracer.Tracer.Traced])
[warn]
[warn] ──────────────────────────────────────────────────────────────────────
There was a problem hiding this comment.
@zhrebicek Have you tried just removing .provideSome[R](ZLayer.succeed(releaseMap)) from the code? It's probably more complicated than that, but just want to make sure you've tried the easiest thing before troubleshooting further.
There was a problem hiding this comment.
@swoogles it seems to make compiler happy, but I should write some test around it if it behaves as expected. And I am not sure when I would have time for it.
|
All tests are passing but this one |
Merged
|
@adamgfraser finished it in his own PR. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should take care of #422
Still missing some compilation errors.