Support for scala-native #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianReeves
reviewed
Sep 4, 2023
There was a problem hiding this comment.
Awesome work. On a whole this looks great, I just had one nit with the duplication of ZStreamHelper.
@jdegoes I think this can claim the bounty.
There was a problem hiding this comment.
Why not share ZSteamHelper instead of copy paste?
There was a problem hiding this comment.
Great, I hope it's useful!
Yes, you're right. It belongs in shared. Actually it contains existing ZStream constructors only implemented for JVM in zio-streams. I've made PR zio/zio#8364 to include them. I plan to delete ZStreamHelper when that PR is available, so maybe it's better to wait until they are available from zio-streams.
adamgfraser
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #612
@DamianReeves Hi! I hope the PR has what you need. Everything is supported except method
newWatchServiceofzio.nio.file.FileSystemand part ofzio.nio.channelsas they are not yet implemented in scala-native.