-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply ZIO SBT Ecosystem and CI Plugins #1096
base: series/2.x
Are you sure you want to change the base?
Conversation
I'm all for improving our CI/sbt story (which I know currently is less than ideal)... But wow, the number of GitHub Actions jobs is huge! I'm worried that it wouldn't be reasonable to have such high number, each PR would be very expensive and take a long time to complete. Or keep the original idea where JVM 17, Scala 2.13 and JVM platform are the default and we diverge from it only in one axis. |
@sideeffffect |
I added an option to limit the parallel task on the matrix strategy. Also, grouped tests together based on scala and java versions, to make them more sequential. |
@khajavi So it seems like this has resulted in a dramatic increase in CI times. It is taking around 20 minutes for these tests now versus it previously took around 4 minutes after we merged my PR upgrading the ZIO version. Can we please maintain the current execution semantics? |
@adamgfraser Okay, I will try to reduce the duration of the CI process. If this does not lead to any improvement, we need to consider discontinuing automatic test generation. |
I'll update this after each try:
|
e30a15f
to
e7409ba
Compare
e7409ba
to
b04d151
Compare
@adamgfraser To accomplish this task, I utilized the existing semantic, as you said, and attempted to migrate it to the zio-sbt plugin. This involved applying mostly the same workflows used in the original code to the version. By doing so, I expect to have the same level of quality as the current workflow execution. |
@khajavi, Could you update this PR, maybe, please? I'd be interested in merging these changes 🙂 |
@guizmaii |
No description provided.