Unify ZQuery.foreach implementations and cleanups
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Apr 7, 2024
| } else | ||
| Promise.makeAs[E, B](fiberId).map { promise => | ||
| } else { | ||
| ZIO.succeed { |
There was a problem hiding this comment.
Out of curiosity, why this change? Isn't Promise.makeAs doing the same thing?
There was a problem hiding this comment.
Because when using Promise.makeAs we have to use .map afterwards (which is an extra flatMap). Since this is run for every ZQuery.fromRequest, I think it's worth to use the unsafe method in order to reduce the overall number of flatMaps in the query
ghostdogpr
previously approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR is that we unify the implementation for
foreach,foreachParandforeachBatched. This way, theforeachandforeachParmethods can take advantage of the optimizations that were done in #457.The other somewhat big change is adding a dependency on
scala-collection-compat. I was a bit divided about this at first, but I think it's likely for the best as I kept finding myself having to write workarounds for missing constructors / methods in Scala 2.12.