Remove useless match in liftTokenizer
#2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
commented
Sep 30, 2023
Comment on lines
+22
to
+25
| implicit final val jsonAstEncoder: Encoder[JsonValue[Json]] = astEncoder(_.value.toString(), "json") | ||
| implicit final val jsonAstDecoder: Decoder[JsonValue[Json]] = astDecoder(JsonValue(_)) | ||
| implicit final val jsonbAstEncoder: Encoder[JsonbValue[Json]] = astEncoder(_.value.toString(), "jsonb") | ||
| implicit final val jsonbAstDecoder: Decoder[JsonbValue[Json]] = astDecoder(JsonbValue(_)) |
There was a problem hiding this comment.
We don't need to compute them more than once
guizmaii
commented
Sep 30, 2023
Comment on lines
+22
to
+25
| implicit final val jsonAstEncoder: Encoder[JsonValue[Json]] = astEncoder(_.value.toString(), "json") | ||
| implicit final val jsonAstDecoder: Decoder[JsonValue[Json]] = astDecoder(JsonValue(_)) | ||
| implicit final val jsonbAstEncoder: Encoder[JsonbValue[Json]] = astEncoder(_.value.toString(), "jsonb") | ||
| implicit final val jsonbAstDecoder: Decoder[JsonbValue[Json]] = astDecoder(JsonbValue(_)) |
There was a problem hiding this comment.
We don't need to compute them more than once
guizmaii
commented
Sep 30, 2023
Comment on lines
+95
to
+100
| implicit val tokenTokenizer: Tokenizer[Token] = Tokenizer[Token](identity) | ||
| implicit val statementTokenizer: Tokenizer[Statement] = | ||
| Tokenizer[Statement](identity) | ||
| implicit def stringTokenTokenizer: Tokenizer[StringToken] = | ||
| implicit val stringTokenTokenizer: Tokenizer[StringToken] = | ||
| Tokenizer[StringToken](identity) | ||
| implicit def liftingTokenTokenizer: Tokenizer[ScalarLiftToken] = | ||
| implicit val liftingTokenTokenizer: Tokenizer[ScalarLiftToken] = |
There was a problem hiding this comment.
We don't need to compute them more than once
guizmaii
commented
Sep 30, 2023
Comment on lines
-54
to
-58
| case tag: ScalarTag => ScalarTagToken(tag) | ||
| case tag: QuotationTag => QuotationTagToken(tag) | ||
| case lift: ScalarLift => ScalarLiftToken(lift) | ||
| // TODO Longer Explanation | ||
| case lift: Tag => fail("Cannot tokenizer a non-scalar tagging.") |
There was a problem hiding this comment.
AFAICT, a Lift can't be a ScalarTag, nor a QuotationTag nor a Tag
There was a problem hiding this comment.
Good catch! I think there was a point at which Tag was a sub-type of Lift but I changed that a while ago.
guizmaii
commented
Sep 30, 2023
| new Tokenizer[T] { | ||
| private val stable = fallback(this) | ||
| override def token(v: T) = pf.applyOrElse(v, stable.token) | ||
| private lazy val stable: Tokenizer[T] = fallback(this) |
There was a problem hiding this comment.
This was weird to me. Why would we need to compute the fallback value before to know if we'll ever need it one day? 🤔
deusaquilus
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this thanks to research done in #2886