Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer mutable data structure to reduce memory usage in macros #2932

Merged
merged 5 commits into from
Oct 21, 2023
Merged

Prefer mutable data structure to reduce memory usage in macros #2932

merged 5 commits into from
Oct 21, 2023

Conversation

guizmaii
Copy link
Member

@guizmaii guizmaii commented Oct 20, 2023 •
edited
Loading

Also, instead of prepending and at the end to call .reverse, I append

See:

@guizmaii guizmaii changed the title Prefer mutable data structure for speed Prefer mutable data structure to reduce memory usage in macros Oct 20, 2023
@guizmaii guizmaii marked this pull request as ready for review October 20, 2023 18:04
@guizmaii
Prefer mutable data structure to reduce memory usage in macros (#2933)
9d2bfc0 
* Prefer mutable data structure to reduce memory usage in macros

* Prefer mutable data structure to reduce memory usage in macros
@guizmaii guizmaii marked this pull request as draft October 21, 2023 07:43
@guizmaii guizmaii marked this pull request as ready for review October 21, 2023 13:32
juliano
juliano approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@juliano juliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@guizmaii guizmaii merged commit 65a2b97 into master Oct 21, 2023
@guizmaii guizmaii deleted the mutable branch October 21, 2023 15:40
jilen pushed a commit that referenced this pull request Jun 11, 2024
@guizmaii
Prefer mutable data structure to reduce memory usage in macros (#2932)
348c8e5 
* Prefer mutable data structure for speed

* Prefer mutable data structure to reduce memory usage in macros (#2933)

* Prefer mutable data structure to reduce memory usage in macros

* Prefer mutable data structure to reduce memory usage in macros

* Prefer mutable data structure to reduce memory usage in macros

* Prefer mutable data structure to reduce memory usage in macros

* Prefer ListBuffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliano juliano juliano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guizmaii @juliano