Derive zio.test.Gen #161
Merged
Derive zio.test.Gen #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
|
@thinkharderdev Hey Dan! Could you have a look at this PR?! |
Comment on lines
464
to
468
| private def genSequence[Z, A](seq: Schema.Sequence[Z, A]): Gen[Random with Sized, Z] = | ||
| Gen.chunkOf1(gen(seq.schemaA)).map(nec => seq.fromChunk(nec.toChunk)) | ||
|
|
||
| private def genMap[K, V](map: Schema.MapSchema[K, V]): Gen[Random with Sized, Map[K, V]] = | ||
| Gen.mapOf1(gen(map.ks), gen(map.vs)) |
There was a problem hiding this comment.
For these two I would not restrict to single-element chunks (at the very least we should sometimes generate an empty Chunk). So maybe a chunk bounded by 0 and 2? I know in other places we run into severe performance issues if we don't restrict to small(ish) collection sized.
There was a problem hiding this comment.
Yes, I was concerned about chunk's arbitrary size and that's why I did single-element chunks).
No problem, I will bound the chunk by 0 and 2
landlockedsurfer
pushed a commit
to landlockedsurfer/zio-schema
that referenced
this pull request
May 28, 2022
Co-authored-by: Dan Harris <1327726+thinkharderdev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My second attempt on resolving #56.
I've renewed this pr due to recent changes in zio-schema