Fix protobuf semidynamic encoding/decoding #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoo
reviewed
May 26, 2022
| case Schema.Enum4(c1, c2, c3, c4, _) => enumDecoder(c1, c2, c3, c4) | ||
| case Schema.Enum3(c1, c2, c3, _) => enumDecoder(c1, c2, c3) |
There was a problem hiding this comment.
Please undo this reordering :)
vigoo
requested changes
May 26, 2022
vigoo
previously approved these changes
May 27, 2022
vigoo
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoding of semidynamic values should conform to the protobuf encoding protocol. Each encoded object should be preceded by a length-limited tag.
With the current setup, the semidynamic encoder just concatenates the encoded schema act bytes and the encoded value bytes. This causes issues in the following scenario:
Encode a top-level enum, whose case wraps a semidynamic schema. When decoding, the enum decoder will read the length-delimited tag for the encoded ast which doesn't include the total length (its missing the encoded value). This is because top-level values don't encode any tag, but the top-level enum decoder will still find a length-limited tag and skip the rest of the message. This is needed by zit-flow's Remote values, more details in this issue: zio/zio-flow#144
My fix is that semidynamic should encode a tuple, so the attached length-delimited tag will include the correct message length.