Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3: don't make the self ref vals private within #555

Merged
merged 1 commit into from
May 17, 2023

Conversation

KacperFKorban
Copy link
Contributor

@KacperFKorban KacperFKorban commented May 8, 2023

When creating symbols, their privateWithin has to be a type.
When defining zio-schema derivation e.g.

given x: Schema[ArangoError] = DeriveSchema.gen[ArangoError]

Symbol.spliceOwner of the derivation macro was x. Which is not a correct value for privateWithin.

This property will now be enforced with scala/scala3#17352

EDIT: Also after this fix -Xprint should work for programs using zio-schema derivations.

@jdegoes
Copy link
Member

jdegoes commented May 10, 2023

Thank you! Can you run sbt docs/generateReadme to update the README, then the CI build can make further progress!

@KacperFKorban
Copy link
Contributor Author

@jdegoes rebased, the CI is green now

@jdegoes jdegoes merged commit 62ace4d into zio:main May 17, 2023
@jdegoes
Copy link
Member

jdegoes commented May 17, 2023

@KacperFKorban Thank you for your pull request and detailed explanation of the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants