Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add makedate function to MysqlSqlModule #655

Closed
jczuchnowski opened this issue May 23, 2022 · 2 comments
Closed

Add makedate function to MysqlSqlModule #655

jczuchnowski opened this issue May 23, 2022 · 2 comments
Labels
good first issue Good for newcomers MySQL ziohackathon

Comments

@jczuchnowski
Copy link
Member

jczuchnowski commented May 23, 2022 •
edited
Loading

Add support for function makedate described in the MySQL docs.

Add function to MysqlFunctionDef in MysqlSqlModule
Add test in FunctionDefSpec
@jczuchnowski jczuchnowski changed the title Add make_date function to MysqlSqlModule Add makedate function to MysqlSqlModule May 23, 2022
@peixunzhang
Copy link
Contributor

I will take this ticket.

peixunzhang added a commit to peixunzhang/zio-sql that referenced this issue May 26, 2022
@peixunzhang
Add makedate function to MysqlSqlModule zio#655
91ac617
sviezypan added a commit that referenced this issue May 27, 2022
@sviezypan
Merge pull request #671 from peixunzhang/655
cec08b3 
Add makedate function to MysqlSqlModule #655
@jczuchnowski
Copy link
Member Author

Done in #671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers MySQL ziohackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdegoes @jczuchnowski @peixunzhang