Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that connections are released after interrupt #605

Merged
merged 8 commits into from
Mar 20, 2022
Merged

Ensure that connections are released after interrupt #605

merged 8 commits into from
Mar 20, 2022

Conversation

petoalbert
Copy link
Contributor

@petoalbert petoalbert requested a review from a team as a code owner March 15, 2022 12:50
@CLAassistant
Copy link

CLAassistant commented Mar 15, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sviezypan
Copy link
Collaborator

hey @petoalbert thanks so much for your work on this. This is a great catch.
Could you add example from #604 as a test?
Also please run sbt fmt to format the code.

@sviezypan sviezypan merged commit c8f894e into zio:master Mar 20, 2022
amrkamel pushed a commit to amrkamel/zio-sql that referenced this pull request May 26, 2022
@sviezypan
Merge pull request zio#605 from petoalbert/fix-connection-release-on-…
f044a7b 
…interrupt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sviezypan sviezypan sviezypan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petoalbert @CLAassistant @sviezypan