Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack 652 - https://github.com/zio/zio-sql/issues/652 #667

Merged
merged 10 commits into from
May 26, 2022
Merged

Hack 652 - https://github.com/zio/zio-sql/issues/652 #667

merged 10 commits into from
May 26, 2022

Conversation

AdityaVetukuri
Copy link
Contributor

@AdityaVetukuri AdityaVetukuri commented May 26, 2022 •
edited
Loading

@AdityaVetukuri AdityaVetukuri requested a review from a team as a code owner May 26, 2022 10:59
@CLAassistant
Copy link

CLAassistant commented May 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jczuchnowski
Copy link
Member

jczuchnowski commented May 26, 2022 •
edited
Loading

@AdityaVetukuri it looks good codewise, but you need to:

  1. Accept the CLA
  2. Add some imports to fix the compilation errors
  3. Run sbt fmt to fix formatting

@AdityaVetukuri AdityaVetukuri changed the title Hack 652 Hack 652 - https://github.com/zio/zio-sql/issues/652 May 26, 2022
jczuchnowski
jczuchnowski reviewed May 26, 2022
View reviewed changes
mysql/src/main/scala/zio/sql/mysql/MysqlSqlModule.scala Outdated
val Log10 = FunctionDef[Double, Double](FunctionName("log10"))
val Pi = Expr.FunctionCall0[Double](FunctionDef[Any, Double](FunctionName("pi")))
val BitLength = FunctionDef[String, Int](FunctionName("bit_length"))
val CurrentDate = Expr.ParenlessFunctionCall0[LocalDate](FunctionName("current_date"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please place the CurrentDate alphabetically after Crc32. And along the way BitLength at the begining?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Thanks for the feedback!

@jczuchnowski
Copy link
Member

@AdityaVetukuri just one more small change.

@AdityaVetukuri
Copy link
Contributor Author

Thanks, I have signed the CLA too.

@jczuchnowski jczuchnowski merged commit adc7a58 into zio:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jczuchnowski jczuchnowski jczuchnowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdityaVetukuri @CLAassistant @jczuchnowski