Clean up examples #668
Merged
Clean up examples #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks good and nicely done. |
jczuchnowski
approved these changes
May 26, 2022
amrkamel
pushed a commit
to amrkamel/zio-sql
that referenced
this pull request
May 26, 2022
Clean up examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlServerJdbcModuletoPostgresJdbcModule. Aside from supporting Open Source DBMS, certain functions don't work withSqlServerJdbcModule, eg.Offset. That said, I also found out thatAsdoesn't work for Postgres and MySQL but it's out of scope for this PR.Feedback is very much appreciated!