Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

Permissions are not copied in raw_copy_file_rename #252

Closed
dzamlo opened this issue Sep 29, 2021 · 2 comments
Closed

Permissions are not copied in raw_copy_file_rename #252

dzamlo opened this issue Sep 29, 2021 · 2 comments
Assignees
Labels

Comments

@dzamlo
Copy link

dzamlo commented Sep 29, 2021

When using the raw_copy_file_rename method (and the raw_copy_file method that call it), the permission are not copied.

The issue is with this line:
https://github.com/zip-rs/zip/blob/7edf2489d5cff8b80f02ee6fc5febf3efd0a9442/src/write.rs#L610

When calling the setters on FileOptions, the original one is not modified because the struct is Copy and thus the method is called with an implicit copy and not a reference to the original one.

@zamazan4ik zamazan4ik added the bug label Jan 22, 2022
@zamazan4ik
Copy link
Contributor

zamazan4ik commented Jan 22, 2022

@dzamlo Thanks for the issue! Maybe you already have the proper fix for the library? Any PR is welcome!

@zamazan4ik
Copy link
Contributor

Fixed in #264

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants