This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
fix: permissions are not copied #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #252 |
Plecra
approved these changes
Jan 23, 2022
|
I wonder if we could make this easier to catch in future reviews, or just need to remember. Would |
|
Maybe this thread will be helpful for us: rust-lang/rust#48926 |
|
Maybe another option is divide this struct into |
|
Ah, you're right, that issue does help. We ought to just add |
|
Sure, will do it |
- fix a small bug when permissions where not copied - add must_use attribute to the all FileOptions methods Tested: - No
zamazan4ik
force-pushed
the
fix/issue_252
branch
from
c1aef97
to
5a4ca95
Compare
|
Done for all methods, except |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested: