Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Enable doc_auto_cfg feature with Docs.rs #135

Merged
merged 2 commits into from
May 18, 2024

Conversation

sorairolake
Copy link
Contributor

@sorairolake sorairolake commented May 18, 2024

Currently, the documentation cannot be built when the deflate-zopfli feature is enabled (see zopfli-rs/zopfli#42). So I think when this issue is resolved it will be possible to build the documentation with all-features = true.

To reproduce locally:

env RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc -F "aes-crypto bzip2 chrono deflate deflate64 deflate-zlib-ng lzma time zstd" --no-default-features

Screenshots:

DateTime
CompressionMethod

@sorairolake sorairolake marked this pull request as draft May 18, 2024 00:40
This is to enable `doc_auto_cfg` feature with Docs.rs.
@sorairolake sorairolake marked this pull request as ready for review May 18, 2024 01:04
Cargo.toml Show resolved Hide resolved
deflate-zlib was an omission; deflate64 is a different, backward-incompatible algorithm.

Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
@Pr0methean Pr0methean enabled auto-merge May 18, 2024 02:10
@Pr0methean
Copy link
Member

Thanks for fixing this; this PR will be merged tonight or tomorrow.

@Pr0methean Pr0methean added this pull request to the merge queue May 18, 2024
Merged via the queue into zip-rs:master with commit 4b295d3 May 18, 2024
38 checks passed
@sorairolake sorairolake deleted the docsrs branch May 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants