zip64: fix zip64 extended information issue #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes #192 tested with the code snippets in #192. |
|
This does indeed fix an issue we have seen in rattler-build. Would be great if this can get merged and released. Let me know if there is any way we can help! |
Pr0methean
previously approved these changes
Nov 19, 2024
|
CI failed in crypto case, need more investigate. |
Signed-off-by: onlyxuyang <onlyxuyang@foxmail.com>
auto-merge was automatically disabled
November 20, 2024 15:36
Head branch was pushed to by a user without write access
|
sorry, pull request status is not well, close this pull request and key a new PR. |
|
new PR created #265 fix issue in crypto case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix zip64 extended information issue to fix zip file incorrect if size larger than 4GB.
According zip format 4.5.3: