feat: Add lzma-static and xz-static features that enable liblzma/static
#393
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Pr0methean, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new "lzma-static" feature to the project, allowing users to opt for static linking of the "liblzma" library. The default feature set has been updated to leverage this new static linking option, ensuring that LZMA compression utilizes the statically linked library by default. Additionally, the change includes a minor correction to the dependency syntax for existing "flate2" related features.
Highlights
- New Feature: lzma-static: A new "lzma-static" feature has been added to Cargo.toml. This feature enables static linking for liblzma by depending on "liblzma/static".
- Default Feature Update: The "default" features list has been updated to use the newly introduced "lzma-static" feature instead of the previous "lzma" feature, making static linking the default behavior for LZMA compression.
- Dependency Syntax Correction: Corrected the dependency syntax for "flate2/zlib-rs" and "flate2/zlib" within the "deflate-flate2-zlib-rs" and "deflate-flate2-zlib" features, respectively, by adding the "dep:" prefix.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
✅ I finished the code review, and didn't find any security or code quality issues. |
There was a problem hiding this comment.
Code Review
This pull request introduces a lzma-static feature to enable static linking for liblzma, making it a default. It also updates feature syntax. My review suggests a refinement to this new feature for better consistency and clarity, by creating a single feature to control static linking for the liblzma dependency that covers all compression methods using it (lzma and xz).
| jiff-02 = ["dep:jiff"] | ||
| nt-time = ["dep:nt-time"] | ||
| lzma = ["dep:liblzma"] | ||
| lzma-static = ["lzma", "liblzma/static"] |
There was a problem hiding this comment.
Since both the lzma and xz features depend on the liblzma crate, it would be clearer to have a single feature for controlling the static linking of this dependency. Consider renaming lzma-static to something more general like liblzma-static and have it enable both compression method features.
This would make it explicit that this feature affects the entire liblzma dependency and all features that rely on it.
| lzma-static = ["lzma", "liblzma/static"] | |
| liblzma-static = ["lzma", "xz", "dep:liblzma/static"] |
Pr0methean
changed the title
lzma-static feature that enables liblzma/staticlzma-static and xz-static features that enable liblzma/static
…/static` (zip-rs#393) * feat: Add `lzma-static` feature that enables `liblzma/static` * fix: Cargo doesn't allow `dep:` with a dependency-feature slash * feat: Add xz-static feature as well
Fixes #379.