fix: Pin generic-array to an old version to work around https://github.com/RustCrypto/traits/issues/2036 until next RustCrypto & aes-crypto releases

[Pr0methean]

No description provided.

[amazon-q-developer]

⏳ Code review in progress. Analyzing for code quality issues and best practices. You can monitor the review status in the checks section at the bottom of this pull request. Detailed findings will be posted upon completion.

Using Amazon Q Developer for GitHub

Amazon Q Developer¹ is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation.

Slash Commands

Command	Description
/q <message>	Chat with the agent to ask questions or request revisions
/q review	Requests an Amazon Q powered code review
/q help	Displays usage information

Features

Agentic Chat
Enables interactive conversation with Amazon Q to ask questions about the pull request or request specific revisions. Use /q <message> in comment threads or the review body to engage with the agent directly.

Code Review
Analyzes pull requests for code quality, potential issues, and security concerns. Provides feedback and suggested fixes. Automatically triggered on new or reopened PRs (can be disabled for AWS registered installations), or manually with /q review slash command in a comment.

Customization

You can create project-specific rules for Amazon Q Developer to follow:

1. Create a .amazonq/rules folder in your project root.
2. Add Markdown files in this folder to define rules (e.g., cdk-rules.md).
3. Write detailed prompts in these files, such as coding standards or best practices.
4. Amazon Q Developer will automatically use these rules when generating code or providing assistance.

Example rule:

All Amazon S3 buckets must have encryption enabled, enforce SSL, and block public access.
All Amazon DynamoDB Streams tables must have encryption enabled.
All Amazon SNS topics must have encryption enabled and enforce SSL.
All Amazon SNS queues must enforce SSL.

Feedback

To provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository.

For more detailed information, visit the Amazon Q for GitHub documentation.

Footnotes

1. Amazon Q Developer uses generative AI. You may need to verify generated code before using it in your environment. See the AWS Responsible AI Policy. ↩

[gemini-code-assist]

Summary of Changes

Hello @Pr0methean, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical fix by pinning the generic-array dependency to a specific older version. This action is a direct response to a known compatibility issue within the RustCrypto/traits ecosystem, which was causing problems with the aes-crypto feature. By temporarily locking this dependency, the PR ensures the stability and functionality of the crate for users relying on AES cryptography until upstream issues are resolved and new releases are made.

Highlights

• Dependency Pinning: The generic-array crate has been explicitly pinned to version 0.14.7 in Cargo.toml.
• Workaround for Known Issue: This pinning serves as a temporary workaround for a known compatibility issue (generic-array 0.x deprecation warnings RustCrypto/traits#2036) affecting RustCrypto and aes-crypto until new releases of these crates are available.
• Feature Integration: The generic-array dependency is now included as part of the aes-crypto feature, ensuring its availability when this feature is enabled.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[amazon-q-developer]

Summary

This PR addresses a compatibility issue with the RustCrypto ecosystem by pinning generic-array to version 0.14.7. The changes are minimal and focused:

✅ Positive aspects:

• Correctly adds the dependency as optional and gates it behind the aes-crypto feature flag
• Follows the project's guidelines for feature flag dependencies
• PR title conforms to Conventional Commits format with fix: prefix
• Addresses a legitimate compatibility issue with upstream dependencies

⚠️ Considerations:

• The exact version pinning (=0.14.7) is quite restrictive and may cause version conflicts for downstream users
• Consider using a more flexible version constraint like ~0.14.7 to allow patch updates while avoiding breaking changes

Recommendation: The approach is sound for a temporary workaround, but monitor for upstream fixes and consider relaxing the version constraint once the RustCrypto issue is resolved. The change correctly implements the feature flag pattern and maintains the project's dependency management standards.

---

Coming soon: You'll be able to request the agent to implement changes and create commits on your pull request's source branch. This may trigger any configured CI/CD workflows automatically.

You can disable any CI/CD workflow that you have configured to run on the source branch of the pull request. For more information, see Disabling and enabling a workflow in the GitHub documentation.

[gemini-code-assist]

Code Review

This pull request pins the generic-array dependency to version =0.14.7 to work around an upstream issue. This is a reasonable temporary fix. I've added one suggestion to improve the Cargo.toml feature definition for consistency and readability by using the dep: prefix for all optional dependencies and sorting them.